sdk: remove Linux dependencies #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elchead
force-pushed
the
as/darwin-sdk
branch
2 times, most recently
from
a03f229 to
265c4e3
Compare
elchead
added
no changelog
katexochen
reviewed
Nov 28, 2024
coordinator/main.go
Outdated
| @@ -154,7 +155,7 @@ func newServerMetrics(reg *prometheus.Registry) *grpcprometheus.ServerMetrics { | |||
| } | |||
|
|
|||
| func newGRPCServer(serverMetrics *grpcprometheus.ServerMetrics, log *slog.Logger) (*grpc.Server, error) { | |||
| issuer, err := atls.PlatformIssuer(log) | |||
| issuer, err := issuer.PlatformIssuer(log) | |||
elchead
force-pushed
the
as/darwin-sdk
branch
from
602f95a to
74f06cd
Compare
burgerdev
reviewed
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It is currently not possible to build the SDK / CLI on platforms other than Linux. One of the issues is that the imported packages include Linux specific code.
These components don't require it, so they shouldn't depend on it to allow for cross-platform usage.
AB#4959
Proposed changes